search

hashicorp / terraform-provider-azuread

Terraform provider for Azure Active Directory
https://registry.terraform.io/providers/hashicorp/azuread/latest/docs
Mozilla Public License 2.0
417 stars 283 forks source link

Incorrect Import Id in Documentation #1338

Open nerddtvg opened 4 months ago

nerddtvg commented 4 months ago

https://github.com/hashicorp/terraform-provider-azuread/blob/66ba716e6e3eaf11ad5c5edf8c2d226adea2df39/docs/resources/access_package_resource_package_association.md?plain=1#L60-L68

This references an import id in the format:

{AccessPackageID}/{ResourceRoleScope}/{ResourceOriginID}/{AccessType}

However, the format in the code is:

{accessPackageId}/{resourcePackageAssociationId}/{originId}/{accessType}

The resourcePackageAssociationId is different. The documentation explains a Role_Scope format but there is no role or scope to this resource.

nerddtvg commented 4 months ago

I think my issue is the wording of Role_Scope is not exactly defined in the documentation. The Id is in the right format (guid_guid), but there is no indication what either value is.

dvasdekis commented 3 months ago

Likewise, import of application is wrong. It should be terraform import azuread_application.example 00000000-0000-0000-0000-000000000000 not terraform import azuread_application.example /applications/00000000-0000-0000-0000-000000000000