Removing group members using azuread_group_member throws an error although members are being removed

J3d3r commented 7 months ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritise this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritise the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureAD Provider) Version

Terraform v1.3.10 on windows_amd64

provider registry.terraform.io/hashicorp/azuread v2.47.0
provider registry.terraform.io/hashicorp/azurerm v3.98.0
provider registry.terraform.io/hashicorp/local v2.5.1

Affected Resource(s)

azuread_group_member

Terraform Configuration Files

resource "azurerm_resource_group" "resource_group" {
  name     = "test-managed-identity"
  location = "West Europe"
}

resource "azurerm_service_plan" "app_service_plan" {
  name                     = "test-managed-identity-asp"
  resource_group_name      = azurerm_resource_group.resource_group.name
  location                 = azurerm_resource_group.resource_group.location
  os_type                  = "Linux"
  sku_name                 = "B1"
  worker_count             = "1"
  per_site_scaling_enabled = false
}

resource "azurerm_linux_web_app" "linux_web_app" {
  name                = "test-managed-identity-webapp"
  resource_group_name = azurerm_resource_group.resource_group.name
  location            = azurerm_service_plan.app_service_plan.location
  service_plan_id     = azurerm_service_plan.app_service_plan.id
  https_only          = true

  identity { type = "SystemAssigned" }

  site_config {
    ftps_state          = "FtpsOnly"
    minimum_tls_version = "1.2"
  }
}

resource "azuread_group_member" "group_member" {
  group_object_id  = "some existing group object id where the service principal performing the operation is an owner"
  member_object_id = azurerm_linux_web_app.linux_web_app.identity.0.principal_id
}

Debug Output

Issue is easy to reproduce. Nothing interesting to see in the logs. I will only paste small output here...

azuread_group_member.group_member: Destroying... [id=/member/] ╷ │ Error: Waiting for removal of member "" from group with object ID "" │ │ retrieving resource: GroupsClient.BaseClient.Get(): unexpected status 403 with OData error: Authorization_RequestDenied: Insufficient privileges to complete the operation. ╵ Error occurred while executing scripts! Press any key to continue . . .

Expected Behavior

When the "azuread_group_member" resource is being removed from the configuration the actual group member should be removed from the group without throwing any errors.

Actual Behavior

Terraform is throwing an error (see above) about "Insufficient privileges...". The group member is still being removed which indicates that the permissions are right but Terraform is somehow misbehaving.

Steps to Reproduce

Create a group where your service principal used for deployments is being an owner
Add Application.Read.All permissions to your service principal to be able to read managed identities from Entra ID
Copy the configuration above and adapt it to your setup (e.g. add group object id...)
Run terraform apply

Important Factoids

Please note that according to the Terraform docs no additional API permission should be required for using "azuread_group_member" if the service principal used for deployment is being an owner of the group in question (https://registry.terraform.io/providers/hashicorp/azuread/latest/docs/resources/group_member#api-permissions). This is at least not correct if the members that should be added to the group are managed identities. In this case "Application.Read.All" API permission is required.

References

Similar issue but with adding group members. Perhaps "Application.Read.All" API permission is missing here... https://github.com/hashicorp/terraform-provider-azuread/issues/1202https://github.com/hashicorp/terraform-provider-azuread/issues/1202

0000

johnsonp57 commented 6 months ago

We get the same problem trying to remove a group member, even though the user performing the operation in a group owner. We are using Pulumi, but that uses the Terraform AD provider under the hood

rossbuggins commented 1 week ago

Having the same issue with tf 1.9.8 and azuread 3.0.2, are you still seeing the problem / any fix?

https://github.com/hashicorp/terraform-provider-azuread/blob/51bd998da1b6324977f409d8d2d0c63362eedf73/internal/services/groups/groups.go#L75

https://github.com/hashicorp/go-azure-sdk/blob/1e84839355b4750048182f630a6a09a5c43437e1/microsoft-graph/groups/beta/member/method_listmembers.go#L107

hashicorp / terraform-provider-azuread