azuread_conditional_access_policy: improve handling of the `session_controls` block - Githubissues

hashicorp / terraform-provider-azuread

Terraform provider for Azure Active Directory

https://registry.terraform.io/providers/hashicorp/azuread/latest/docs

Mozilla Public License 2.0

415 stars 280 forks source link

azuread_conditional_access_policy: improve handling of the `session_controls` block #1382

Closed manicminer closed 1 month ago

manicminer commented 1 month ago

[!WARNING]
Depends on https://github.com/manicminer/hamilton/pull/282

Make sign_in_frequency_authentication_type and sign_in_frequency_internal both Optional + Computed and remove their default values.
Handle the setting of these default values in the expandConditionalAccessSessionControls() function.
Expand test coverage to all reasonable permutatons of the properties in this block to ensure no trailing diff or incorrect setting of values in the request.

Closes: #1235 Closes: #1347

CHANGELOG

ENHANCEMENTS

dependencies: updating to v0.68.0 of github.com/manicminer/hamilton
azuread_conditional_access_policy - improve handling of the session_controls block

BUG FIXES

azuread_conditional_access_policy - fix a bug that could cause a persistent diff when setting certain properties in the session_controls block

manicminer commented 1 month ago

Test results (failure unrelated)

Screenshot 2024-05-16 at 20 31 32