hashicorp / terraform-provider-azurerm

Terraform provider for Azure Resource Manager
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs
Mozilla Public License 2.0
4.58k stars 4.62k forks source link

Support for Private Endpoint Connections in Media Service Account #10308

Open jcanizalez opened 3 years ago

jcanizalez commented 3 years ago

Community Note

Description

Hoping to get support for the creation and manipulation of Private Endpoint Connections in Azure Media Services Account.

New or Affected Resource(s)

Potential Terraform Configuration

resource "azurerm_media_private_endpoint_connection" "connection" {
  name                              = "connection1"
  resource_group_name               = azurerm_resource_group.media.name
  media_services_account_name       = azurerm_media_services_account.ams.name
  private_link_service_connection_state {
    status = "Approved"
    description = "Test description"
  }
}

References

jackbatzner commented 3 years ago

This looks fun 🙃 , I'll take a stab at it

jackbatzner commented 3 years ago

@jcanizalez - Do you have any more info on this feature? I can't seem to find it in the Azure portal for a media service I have created.

Screen Shot 2021-02-10 at 9 50 16 PM

Acceptance tests in #10537 are failing due to an API error which leads me to think this may not be fully rolled out yet?

media.PrivateEndpointConnectionsClient#Get: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="BadRequest" Message="Private endpoint connection name is not valid"

jcanizalez commented 3 years ago

Thanks @brunhil let me open a ticket with Microsoft to validate this error, because in microsoft documentation request seems its working but I also was able to replicate the error that you said.

jackbatzner commented 3 years ago

Awesome thanks @jcanizalez ! I've also opened a ticket on the REST API specs a well, https://github.com/Azure/azure-rest-api-specs/issues/12976

jackbatzner commented 3 years ago

@jcanizalez , got an update from MSFT

@brunhil - This is result of private endpoint implementation not being completed yet for Azure Media Services. We are tracking towards having implementation complete in first half of this year.

Seems like this and the associated PR (#10537) should have their tags updated. Any chance someone could handle doing this @katbyte / @tombuildsstuff ?