hashicorp / terraform-provider-azurerm

Terraform provider for Azure Resource Manager
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs
Mozilla Public License 2.0
4.46k stars 4.54k forks source link

Expand support for azurerm_purview_account #12334

Closed smitp11 closed 4 months ago

smitp11 commented 3 years ago

Community Note

Description

I would like to expand the capabilities to provision azure purview accounts with terraform https://azure.microsoft.com/en-us/services/purview/

to include the Create Purview Account > Configuration >Managed Resources > Managed Resource Group Name as an argument on the azurerm_purview_account template.

New or Affected Resource(s)

Potential Terraform Configuration

resource "azurerm_purview_account" "example" {
  name                        = "example"
  resource_group_name         = azurerm_resource_group.example.name
  location                    = azurerm_resource_group.example.location
  sku_name                    = "Standard_4"
  managed_resource_group_name = azurerm_resource_group.xxxxxxxxx.name
}

References

mosharief commented 3 years ago

I also want to prioritize this above request for including managed resource group name as an argument.

favoretti commented 3 years ago

Hi there and thank you for reporting this. I see that latest swagger in the API version that we're using supports this, however, azure-sdk-for-go doesn't yet (at least not the version we're on). As soon as SDK is released that supports this property, we'll be able to implement this in provider.

// cc @ArcturusZhang 55.3 doesn't seem to include this yet, would this be coming in the next release? https://github.com/Azure/azure-rest-api-specs/blob/master/specification/purview/resource-manager/Microsoft.Purview/preview/2020-12-01-preview/purview.json#L1037

ArcturusZhang commented 3 years ago

@favoretti please let me to communicate with the corresponding service team to see if it is ready for release

gerardwolf commented 2 years ago

Looks like the GA API is now available: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/purview/resource-manager/Microsoft.Purview/stable/2021-07-01/purview.json

flavio-neves commented 2 years ago

Any plans to onboard "Root collection permission" option?

CherylFlowers commented 2 years ago

Any plans to onboard the sku name and sku capacity?

jdelforno commented 4 months ago

@favoretti I just went snooping through the go SDK and came across this; https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/purview/armpurview

Does this indicate that the go-sdk has been updated and that we could potentially see an update against the provider to see it implemented?

tombuildsstuff commented 4 months ago

Taking a look through here it appears that the managed_resource_group_name field being requested in this issue is supported by the Purview Account resource and as such I'm going to close this issue for the moment - however if you're looking for additional fields/support would you mind opening a new issue so that we can track those enhancements specifically.


@jdelforno FWIW we no longer use Azure/azure-sdk-for-go - but instead use hashicorp/go-azure-sdk - which supports the newer API version (2021-12-01) needed for this feature, which the Provider is already using (meaning that the sdk/not-yet-supported label is now outdated).

github-actions[bot] commented 2 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.