hashicorp / terraform-provider-azurerm

Terraform provider for Azure Resource Manager
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs
Mozilla Public License 2.0
4.52k stars 4.6k forks source link

CDN FrontDoor: support for Firewall Policies #13836

Closed sanderobdeijn closed 1 year ago

sanderobdeijn commented 2 years ago

Community Note

Description

The new Azure Frontdoor premium #11983 also uses a different waf SKU. The rest of the waf config seems to be same. There are now 3 sku's:

New or Affected Resource(s)

Potential Terraform Configuration

resource "azurerm_frontdoor_firewall_policy" "example" {
  name                = "example"
  resource_group_name = azurerm_resource_group.rg.name
  enabled                           = true
  mode                              = "Prevention"
  sku                   = "Premium_AzureFrontDoor"
}

References

https://docs.microsoft.com/en-us/rest/api/frontdoorservice/webapplicationfirewall/policies/create-or-update#sku

aristosvo commented 2 years ago

Hoi @sanderobdeijn! I have taken a short look, but it isn't as easy as adding a variable.

This requires a new API release for Azure FrontDoor, requested here

tombuildsstuff commented 2 years ago

@mbfrahry any chance you could look into switching FrontDoor over to an Embedded SDK?

sanderobdeijn commented 2 years ago

@mbfrahry It says #14093 supercedes this issue. And since #14093 has been merged should this be fixed? I tried to set a SKU but couldn't find a setting in the documentation.

github-actions[bot] commented 1 year ago

This functionality has been released in v3.26.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.