LRO using Azure SDK Track1 forgets to wait

magodo commented 2 years ago

There are quite a few places in the codebase that uses the Azure SDK Track1 that forgets to wait for completion of a LRO.

With the help of https://github.com/magodo/terraform-provider-azurerm-lro, we have below list. This issue is only for tracking purpose, each item shown below should be fixed in a dedicated issue.

Not all of the below items are coding mistakes, since some of them are intentially not calling the wait for LRO, which might due to API issues or Swagger mis-configuration, while for this case we still want to ensure a comment right above the LRO to indicate the reason, with a Github issue link to the https://github.com/Azure/azure-rest-api-specs.

apimanagement

[x] internal/services/apimanagement/api_management_api_schema_resource.go:101:5
[x] internal/services/apimanagement/api_management_custom_domain_resource.go:185:5
[x] internal/services/apimanagement/api_management_custom_domain_resource.go:281:5

automation

[x] internal/services/automation/automation_dsc_nodeconfiguration_resource.go:113:5
[x] internal/services/automation/automation_runbook_resource.go:211:6
[x] internal/services/automation/automation_runbook_resource.go:207:6

network

[x] internal/services/network/network_profile_resource.go:233:5
[x] internal/services/network/subnet_service_endpoint_storage_policy_resource.go:181:5
[x] internal/services/network/vpn_gateway_resource.go:234:5
[x] internal/services/network/vpn_gateway_resource.go:262:7
[x] internal/services/network/vpn_gateway_resource.go:319:5

cosmos

[x] internal/services/cosmos/cosmosdb_account_resource.go:1150:5

iothub

[x] internal/services/iothub/iothub_resource.go:727:5
[x] internal/services/iothub/iothub_resource.go:898:5

keyvault

[x] internal/services/keyvault/key_vault_resource.go:359:5

lighthouse

[x] internal/services/lighthouse/lighthouse_assignment_resource.go:96:5
[x] internal/services/lighthouse/lighthouse_assignment_resource.go:155:5
[x] internal/services/lighthouse/lighthouse_definition_resource.go:192:5

mariadb

[x] internal/services/mariadb/mariadb_virtual_network_rule_resource.go:96:5

mssql

[x] internal/services/mssql/mssql_virtual_network_rule_resource.go:107:5

mysql

[x] internal/services/mysql/mysql_virtual_network_rule_resource.go:93:5

netapp

[x] internal/services/netapp/netapp_pool_resource.go:254:5
[ ] internal/services/netapp/netapp_snapshot_policy_resource.go:301:5
[ ] internal/services/netapp/netapp_snapshot_policy_resource.go:364:5
[ ] internal/services/netapp/netapp_snapshot_resource.go:183:5
[ ] internal/services/netapp/netapp_volume_resource.go:660:4
[ ] internal/services/netapp/netapp_volume_resource.go:681:6
[ ] internal/services/netapp/netapp_volume_resource.go:692:5

notificationhub

[x] internal/services/notificationhub/notification_hub_namespace_resource.go:259:6

privatedns

[x] internal/services/privatedns/private_dns_zone_virtual_network_link_resource.go:175:5

recoveryservices

[x] internal/services/recoveryservices/recovery_services_vault_resource.go:184:5

resource

~internal/services/resource/template_deployment_resource.go:274:5~

signalr

[x] internal/services/signalr/web_pubsub_hub_resource.go:152:5

spingcloud

[x] internal/services/springcloud/spring_cloud_app_cosmosdb_association_resource.go:203:5
[x] internal/services/springcloud/spring_cloud_app_cosmosdb_association_resource.go:284:5
[x] internal/services/springcloud/spring_cloud_app_mysql_association_resource.go:122:5
[x] internal/services/springcloud/spring_cloud_app_mysql_association_resource.go:180:5
[x] internal/services/springcloud/spring_cloud_app_redis_association_resource.go:112:5
[x] internal/services/springcloud/spring_cloud_app_redis_association_resource.go:164:5
[x] internal/services/springcloud/spring_cloud_certificate_resource.go:118:5
[x] internal/services/springcloud/spring_cloud_certificate_resource.go:169:5
[x] internal/services/springcloud/spring_cloud_custom_domain_resource.go:102:5
[x] internal/services/springcloud/spring_cloud_custom_domain_resource.go:149:5
[x] internal/services/springcloud/spring_cloud_java_deployment_resource.go:250:5

sql

[x] internal/services/sql/sql_virtual_network_rule_resource.go:96:5

synapse

[x] internal/services/synapse/synapse_workspace_resource.go:653:6

web

[x] internal/services/web/app_service_environment_resource.go:141:5
[x] internal/services/web/app_service_environment_v3_resource.go:292:7
[x] internal/services/web/app_service_environment_v3_resource.go:466:7
~internal/services/web/function_app_resource.go:175:3~
[ ] internal/services/web/static_site_resource.go:140:5

katbyte commented 2 years ago

@magodo i think many of the checks can be checked off now?

magodo commented 2 years ago

@katbyte I've marked the merged one to checked and removed (line through) some closed one due to resource being deprecated. While some checks are remain open as the PRs are closed due to other consideratins (e.g. netapp).

ms-henglu commented 2 years ago

https://github.com/hashicorp/terraform-provider-azurerm/pull/15698 https://github.com/hashicorp/terraform-provider-azurerm/pull/15717

hashicorp / terraform-provider-azurerm