hashicorp / terraform-provider-azurerm

Terraform provider for Azure Resource Manager
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs
Mozilla Public License 2.0
4.6k stars 4.65k forks source link

Support for Service Fabric Managed Cluster Subnet ID (BYO vNET) #17119

Open musaugurlu opened 2 years ago

musaugurlu commented 2 years ago

Is there an existing issue for this?

Community Note

Description

Microsoft has brought bring your own vnet (byovnet) feature to Service Fabric Managed Cluster in the API version 2022-01-01. With this feature, you can set your own subnet id to the managed cluster. Microsoft's rest API reference documentation shows 2018-02-01 API version as the latest API version, but Service Fabric's own documentation shows the 2022-01-01 API version as the latest. Azure's resource explorer shows the subnetId option, too (https://resources.azure.com/subscriptions/\<subscription id>/resourceGroups/\<rg name>/providers/Microsoft.ServiceFabric/managedClusters/\<cluster name>).

I was wondering if we can have a subnetid option in the azurerm_service_fabric_managed_cluster resource.

New or Affected Resource(s)/Data Source(s)

azurerm_service_fabric_managed_cluster

Potential Terraform Configuration

resource "azurerm_service_fabric_managed_cluster" "example" {
...
subnetId = /subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/my-sweet-rg/providers/Microsoft.Network/virtualNetworks/my-sweet-vnet/subnets/my-sweet-subnet
...
}

References

https://docs.microsoft.com/en-us/azure/templates/microsoft.servicefabric/2022-01-01/managedclusters

josefernandezatceiba commented 2 years ago

+1

pbaumgartner-rdt commented 2 years ago

+1