New Resource request: Network Watcher Flow Log

liemnotliam commented 6 years ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add support for a new azurerm resource to create and configure network watcher NSG flow logs.

New or Affected Resource(s)

new: azurerm_network_watcher_flow_log

Potential Terraform Configuration

resource "azurerm_network_watcher_flow_log" "test {
    resource_group_name  = "test-rg"
    network_watcher_name = "eastus-networkwatcher"

    enabled            = true
    target_resource_id = "/subscriptions/########-####-####-####-############/resourceGroups/test-rg/providers/Microsoft.Network/networkSecurityGroups/test-nsg"
    storage_account_id = "/subscriptions/########-####-####-####-############/resourceGroups/test-rg/providers/Microsoft.Storage/storageAccounts/networkwatchertestsa"

    retention_policy {
        enabled = true
        days = 7
    }

    traffic_analytics {
        enabled               = true
        workspace_id          = "########-####-####-####-############"
        workspace_region      = "eastus"
        workspace_resource_id = "/subscriptions/########-####-####-####-############/resourcegroups/test-rg/providers/microsoft.operationalinsights/workspaces/test-workspace" 
    }
}

References

https://godoc.org/github.com/Azure/azure-sdk-for-go/services/network/mgmt/2018-04-01/network#WatchersClient.SetFlowLogConfiguration

VikneshR commented 5 years ago

Is there any solution for this case?

ghost commented 5 years ago

Hi, what is the expected availability for this resource ? (azurerm_network_watcher_flow_log)

beaudryj commented 5 years ago

This ⏫

mamade78 commented 5 years ago

Hello any update for this request ?

tombuildsstuff commented 5 years ago

@mamade78

Hello any update for this request ?

As mentioned in the PR - unfortunately this is currently blocked on an issue in the API which is being tracked here: https://github.com/Azure/azure-sdk-for-go/issues/4781. Once the upstream issue's been resolved we'll take another look at this - but unfortunately at this time there's not a lot we can do with the API as-is.

Thanks!

adamday2 commented 5 years ago

@tombuildsstuff although its not completely clear based on the ticket status, it looks like this might be fixed in the upstream now.

JayDoubleu commented 5 years ago

Is there any update on this ? It would be a great resource to use.

draggeta commented 5 years ago

Yeah, if this is fixed upstream, I'd love to see liemnotliam's PR merged.

rem-aj commented 4 years ago

Hi @tombuildsstuff there's a note on the referenced blocker https://github.com/Azure/azure-sdk-for-go/issues/4781 saying the issue was fixed on 8/21. Is it possible to proceed with the request at this point? Thanks!

ymash13 commented 4 years ago

It would be really nice to have this done. I really need it.

schlbra commented 4 years ago

@tombuildsstuff , can you guys please take another look at this since it appears the upstream API has been fixed?

JimmyKarlsson1 commented 4 years ago

Any news on this one?

ghost commented 4 years ago

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

ghost commented 4 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

hashicorp / terraform-provider-azurerm