hashicorp / terraform-provider-azurerm

Terraform provider for Azure Resource Manager
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs
Mozilla Public License 2.0
4.53k stars 4.6k forks source link

Auto-heal slow request path not set for `azurerm_windows_web_app` #19256

Closed dmmusil closed 4 months ago

dmmusil commented 1 year ago

Is there an existing issue for this?

Community Note

Terraform Version

1.1.7

AzureRM Provider Version

3.23 (I checked release notes since 3.23 and don't see any reference to this being fixed)

Affected Resource(s)/Data Source(s)

azurerm_windows_webapp

Terraform Configuration Files

auto_heal_setting = {
      trigger = {
        private_memory_kb = null
        status_codes      = []
        requests          = null
        slow_requests = [
          {
            count      = "5"
            interval   = "00:05:00"
            time_taken = "00:00:10"
            path       = "/health/check"
          }
        ]
      }
      action = {
        action_type                    = "CustomAction"
        minimum_process_execution_time = "00:10:00"
        custom_action = {
          executable = "D:\\home\\data\\DaaS\\bin\\DaasConsole.exe"
          parameters = "-CollectKillAnalyze \"CLR Profiler with Thread Stacks\""
        }
      }
    }

Debug Output/Panic Output

Here's what was planned against one app service.

  ~ site_config {
            # (24 unchanged attributes hidden)

          ~ auto_heal_setting {

              ~ trigger {
                    # (1 unchanged attribute hidden)

                  ~ slow_request {
                      ~ count      = 23 -> 5
                      ~ interval   = "00:03:00" -> "00:05:00"
                      + path       = "/health/check"
                        # (1 unchanged attribute hidden)
                    }
                }
                # (1 unchanged block hidden)
            }
            # (1 unchanged block hidden)
        }

And the result.

Apply complete! Resources: 0 added, 4 changed, 0 destroyed.

Two app services and a slot on each app service were modified, so that's why we see 4 changed. None had their path set correctly.

Expected Behaviour

Path should be set on slow request trigger.

Actual Behaviour

Path is not set.

image

Steps to Reproduce

No response

Important Factoids

No response

References

Fixed by #18227

Wasn't sure about posting an issue on the open PR so I created a new issue instead. Didn't want to clutter the PR review.

xiaxyi commented 1 year ago

Thanks @dmmusil for raising this issue, you can track the status in the mentioned pr. Feel free to let me know if you have any questions or concerns.

github-actions[bot] commented 3 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.