Support for both SystemAssigned and UserAssigned managed identities in azurerm_mssql_managed_instance

tsfto commented 1 year ago

Is there an existing issue for this?

[X] I have searched the existing issues

Community Note

Please vote on this issue by adding a :thumbsup: reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The azurerm_mssql_managed_instance (azurerm_mssql_managed_instance) identity.type accepts either SystemAssigned OR UserAssigned values but NOT both at the same time. I would expect it to accept both managed identity types in a form of identity.type = SystemAssigned, UserAssigned so that both of them are created simultaneously for a particular instance of Azure SQL Server. I want to be able to create a SQL Server instance with the following managed identities:

0..1 System Assigned Managed Identity 0..n User Assigned Managed Identities

This is the same as Support for both SystemAssigned and UserAssigned managed identities in azurerm_mssql_server, but for SQL MI

New or Affected Resource(s)/Data Source(s)

azurerm_mssql_managed_instance

Potential Terraform Configuration

identity {
  type = "SystemAssigned,UserAssigned"
  identity_ids = ["id1", "id2"]
}

primary_user_assigned_identity_id = "id1"

References

https://github.com/hashicorp/terraform-provider-azurerm/issues/17199

djr747 commented 6 months ago

Since late 2022 the version of the Go SDK used by azurerm_mssql_managed_instance has supported supplying SystemAssigned,UserAssigned into IdentityType this should now be unblocked.

References https://pkg.go.dev/github.com/Azure/azure-sdk-for-go@v68.0.0+incompatible/services/preview/sql/mgmt/v5.0/sql#IdentityType

risticmarko commented 2 weeks ago

Since late 2022 the version of the Go SDK used by azurerm_mssql_managed_instance has supported supplying SystemAssigned,UserAssigned into IdentityType this should now be unblocked.

References https://pkg.go.dev/github.com/Azure/azure-sdk-for-go@v68.0.0+incompatible/services/preview/sql/mgmt/v5.0/sql#IdentityType

No that is not working expected identity.0.type to be one of ["UserAssigned" "SystemAssigned"], got SystemAssigned,UserAssigned

hashicorp / terraform-provider-azurerm