hashicorp / terraform-provider-azurerm

Terraform provider for Azure Resource Manager
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs
Mozilla Public License 2.0
4.6k stars 4.64k forks source link

omsAgent profile is wrongly cased - it should be omsagent all lowercase #1983

Closed joby-thomas closed 6 years ago

joby-thomas commented 6 years ago

AKS cluster created with monitoring enabled is broken due to mixed case used in the 'omsAgent' where all other part of the azure is expecting lower case 'omsagent'

https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/data_source_kubernetes_cluster.go

Community Note

Terraform Version

Affected Resource(s)

Terraform Configuration Files

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key: https://keybase.io/hashicorp

Debug Output

Panic Output

Expected Behavior

Actual Behavior

Steps to Reproduce

  1. terraform apply

Important Factoids

References

metacpp commented 6 years ago

Thanks @jobytdev for opening this issue. The naming convention for omsagent is not consistent with httpApplicationRouting, I feel that we'd better make it consistent here.

ghost commented 5 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!