Support for PatchSettings automaticByPlatformSettings

[larsmaes-sogeti]

Is there an existing issue for this?

• [X] I have searched the existing issues

Community Note

• Please vote on this issue by adding a :thumbsup: reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Please implement:

• Automatic by Platform Settings: Linux
• Automatic by Platform Settings: Windows

This is to be able to configure custom update schedules and update reboot policy

New or Affected Resource(s)/Data Source(s)

azurerm_linux_virtual_machine, azurerm_windows_virtual_machine

Potential Terraform Configuration

resource "azurerm_linux_virtual_machine" "vm" {
...
patch_mode = "AutomaticByPlatform"
bypass_platform_safety_checks_on_user_schedule = true
reboot_settings = "IfRequired"
...
}

References

No response

[oswdr]

It seems that the api version in which the field was added to WindowsVMGuestPatchAutomaticByPlatformSettings / LinuxVMGuestPatchAutomaticByPlatformSettings is not yet supported by either tombuildsstuff/kermit/ or hashicorp/go-azure-sdk.

I'm happy to put some effort into this, but I am unsure how to proceed. My guess would be that we would have to request support for api version 2023-03-01 in one of those repositories?

[myc2h6o]

Hi @oswdr you are right, VM has been using /kermit sdk currently and we need an update for the sdk version before onboarding this new feature, I've created https://github.com/tombuildsstuff/kermit/pull/207 to generate the new sdk version

[larsmaes-sogeti]

It seems that the required sdk updates have been merged. Can you take another look at it please?

[brakelee]

Is there any update on this issue? Is this now fixed?

[github-actions[bot]]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.