Add SQL MI managed instance missing attributes in azurerm 3.56.0 (zone_redundant and storage_account_type=GZRS)

LaurentLesle commented 1 year ago

Is there an existing issue for this?

[X] I have searched the existing issues

Community Note

Please vote on this issue by adding a :thumbsup: reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Add support for:

zone_redundant - Whether or not the multi-az is enabled. (bool)
storage_account_type - Add support for GZRS (The storage account type to be used to store backups for this instance. The options are Local (LocallyRedundantStorage), Zone (ZoneRedundantStorage), Geo (GeoRedundantStorage) and GeoZone(GeoZoneRedundantStorage))

Description

Add support for zone_redundant support. Current deployment of SQL MI servers are deployed with zoneRedundant set to false

New or Affected Resource(s)/Data Source(s)

azurerm_mssql_managed_instance

Potential Terraform Configuration

optional attribute. false by default

zone_redundant = true

References

https://learn.microsoft.com/en-us/azure/templates/microsoft.sql/managedinstances?pivots=deployment-language-terraform (version - 2021-11-01)

dtherkil commented 9 months ago

Zone redundancy is now GA for Business Critical Managed Instances so hoping for both these enchancements be implemented soon. GRZS has been for GA for a while.

fgarcia-cnb commented 5 months ago

its been a year since this issue was opened. how has it not been resolved yet? pretty simple fix

Azkel commented 2 months ago

I see that both of those functionalities has been added:

Zone redundancy
GZRS (yesterday)

fgarcia-cnb commented 2 months ago

I changed the replication type to GZRS on an existing sql mi through the portal. unfortunately, according to this article it can take up to 24 hours for the change to take effect, so immediate terraform runs will still see pending changes.

that said, after 24 hours, i see my storage account now has GZRS configured, but terraform runs are still seeing GRS:

current resource JSON:

"currentBackupStorageRedundancy": "GeoZone",
"requestedBackupStorageRedundancy": "GeoZone",

but terraform sees:

somehow its not detecting GZRS. also, going from GRS->GZRS should not force a rebuild. it can be done in place

hashicorp / terraform-provider-azurerm