hashicorp / terraform-provider-azurerm

Terraform provider for Azure Resource Manager
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs
Mozilla Public License 2.0
4.59k stars 4.63k forks source link

azurerm_storage_account cross_tenant_replication_enabled should probably default to false #26127

Open calebak404 opened 5 months ago

calebak404 commented 5 months ago

Is there an existing issue for this?

Community Note

Description

Currently for the azurerm_storage_account resource the provider sets cross_tenant_replication_enabled to true by default.1

According to MS documentation2, as of Dec 15, 2023 the API creates storage accounts with that value as false

The provider should be updated to reflect the default behavior of the API and the portal.

New or Affected Resource(s)/Data Source(s)

azurerm_storage_account

Potential Terraform Configuration

No response

References

1 . https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/storage_account#cross_tenant_replication_enabled

  1. https://learn.microsoft.com/en-us/azure/storage/blobs/object-replication-prevent-cross-tenant-policies?tabs=portal#remediate-cross-tenant-object-replication
Wikiwix commented 1 month ago

26962 already implemented this, so I believe that this can be closed

man0s commented 1 week ago

yes, this can be closed. It's already implemented as @Wikiwix mentioned.