hashicorp / terraform-provider-azurerm

Terraform provider for Azure Resource Manager
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs
Mozilla Public License 2.0
4.61k stars 4.65k forks source link

azurerm_web_application_firewall_policy: Add Support for Disabling Policy Settings #26128

Open The-Real-Justin opened 6 months ago

The-Real-Justin commented 6 months ago

Is there an existing issue for this?

Community Note

Description

Azure has introduced the ability to disable each of the three limits in the Policy Settings section. Can we add this functionality to the terraform please? If it is already there, can we update the documentation to match?

image

New or Affected Resource(s)/Data Source(s)

azurerm_web_application_firewall_policy

Potential Terraform Configuration

I'd suggest that setting the current limit values to 0 would indicate disabled. Otherwise, a Is_Enabled flag for each option to toggle the feature.

References

https://learn.microsoft.com/en-us/azure/web-application-firewall/ag/application-gateway-waf-request-size-limits#request-body-inspection https://learn.microsoft.com/en-us/azure/web-application-firewall/ag/application-gateway-waf-request-size-limits#limits

rajece1989 commented 3 months ago

@mybayern1974 Can we know when this feature will be available.

Currently many customer request to disable this limit as WAF block the application traffic.

audunsolemdal commented 3 months ago

Note that these are three separate flags in the API

        requestBodyCheck = bool
        requestBodyEnforcement = bool
        fileUploadEnforcement = bool

where only request_body_check is implemented in the azurerm_web_application_firewall_policy resource as of now.

The-Real-Justin commented 1 month ago

Is there an update on this issue?