hashicorp / terraform-provider-azurerm

Terraform provider for Azure Resource Manager
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs
Mozilla Public License 2.0
4.61k stars 4.65k forks source link

Removed "virtualNetworkPeerings" property in the request payload for azurerm_virtual_network #26186

Open HaruY96 opened 6 months ago

HaruY96 commented 6 months ago

Is there an existing issue for this?

Community Note

Terraform Version

1.4.6

AzureRM Provider Version

3.68.0

Affected Resource(s)/Data Source(s)

virtual network

Terraform Configuration Files

User-Agent: Go/go1.20.5 (amd64-linux) go-autorest/v14.2.1 hashicorp/go-azure-sdk/activitylogalertsapis/2020-10-01 HashiCorp Terraform/1.4.6 (+https://www.terraform.io) Terraform Plugin SDK/2.10.1 terraform-provider-azurerm/3.68.0

Debug Output/Panic Output

It may contain some credential data so I will not share this file. I will leave the whole story in below sections.

Expected Behaviour

There is nothing changed for the Terraform deployment code and nothing change for the Azure Policy definition.

Before last Monday (5/27), virtual network resources deployed by Terraform worked fine. But since 5/27, the same Terraform deployment failed due to a deny policy which is checking the virtualNetworkPeerings property.

For the failed deployment on 5/27, the following request payload can be checked from TF debug log.

{ "location": "australiaeast", "properties": { "addressSpace": { "addressPrefixes": ["10.xx.xx.0/23"] }, "dhcpOptions": { "dnsServers": ["10.xx.xx.132"] }, "subnets": [{ "id": "/subscriptions/xx/resourceGroups/xx/providers/Microsoft.Network/virtualNetworks/sample-name-VNet1/subnets/sample-name-subnet1", "name": "sample-name-subnet1", "properties": { "addressPrefix": "10.210.250.0/23", "delegations": [], "networkSecurityGroup": { "id": "/subscriptions/xx/resourceGroups/xx/providers/Microsoft.Network/networkSecurityGroups/sample-name-NSG1" }, "privateEndpointNetworkPolicies": "Enabled", "privateLinkServiceNetworkPolicies": "Enabled", "routeTable": { "id": "/subscriptions/xx/resourceGroups/xx/providers/Microsoft.Network/routeTables/sample-name-RT1" }, "serviceEndpoints": [] }, "type": "Microsoft.Network/virtualNetworks/subnets" } ] }, "tags": { ..... } }

For the succeed deployment on 5/14, the following request payload can be checked from Azure Networking resource provider side. (We are working with Azure Networking engineer.)

{ "name": "sample-name-VNet-2", "id": "/subscriptions/xx/resourceGroups/xx/providers/Microsoft.Network/virtualNetworks/sample-name-VNet-2", "etag": "xx"", "type": "Microsoft.Network/virtualNetworks", "location": "australiaeast", "tags": { ... }, "properties": { "provisioningState": "Updating", "resourceGuid": "xx", "addressSpace": { "addressPrefixes": ["10.xx.xx.xx/26"] }, "dhcpOptions": { "dnsServers": ["10.xx.xx.5"] }, "subnets": [], "virtualNetworkPeerings": [], "enableDdosProtection": false } }

The deployment process should be TF->ARM->NRP. ARM will not add/remove property. Obviously, we can see the "virtualNetworkPeerings" property was removed in the failed deployment.

Actual Behaviour

VNet resource deployment failed due to deny policy blocked. The deny policy was triggered due to the missing virtualNetworkPeerings property was removed from request payload.

Steps to Reproduce

No response

Important Factoids

No response

References

No response

ms-henglu commented 6 months ago

Hi @HaruY96 ,

Thank you for taking time to report this issue.

The below trace seems from a response, because it has etag and type set. And I've confirmed that virtualNetworkPeerings property is managed by a separate resource: https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/virtual_network_peering

{
"name": "sample-name-VNet-2",
"id": "/subscriptions/xx/resourceGroups/xx/providers/Microsoft.Network/virtualNetworks/sample-name-VNet-2",
"etag": "xx"",
"type": "Microsoft.Network/virtualNetworks",
"location": "australiaeast",
"tags": {
...
},
"properties": {
"provisioningState": "Updating",
"resourceGuid": "xx",
"addressSpace": {
"addressPrefixes": ["10.xx.xx.xx/26"]
},
"dhcpOptions": {
"dnsServers": ["10.xx.xx.5"]
},
"subnets": [],
"virtualNetworkPeerings": [],
"enableDdosProtection": false
}
}