hashicorp / terraform-provider-azurerm

Terraform provider for Azure Resource Manager
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs
Mozilla Public License 2.0
4.51k stars 4.6k forks source link

AKS Kubelet Config - Support for serializeImagePulls and maxParallelImagePulls #26505

Closed JonathanSiemering closed 2 months ago

JonathanSiemering commented 2 months ago

Is there an existing issue for this?

Community Note

Description

Add support for AKS kubelet configuration of serializeImagePulls and maxParallelImagePulls, so AKS nodes can download images in parallel.

New or Affected Resource(s)/Data Source(s)

azurerm_kubernetes_cluster

Potential Terraform Configuration

resource "azurerm_kubernetes_cluster" "example" {
  name                = "example-aks1"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  dns_prefix          = "exampleaks1"

  default_node_pool {
    name           = "default"
    node_count     = 1
    vm_size        = "Standard_D2_v2"

    kubelet_config {
      serialize_image_pulls    = false
      max_parallel_image_pulls = 10
    }
  }

  identity {
    type = "SystemAssigned"
  }

  tags = {
    Environment = "Production"
  }
}

References

https://kubernetes.io/docs/concepts/containers/images/#serial-and-parallel-image-pulls https://kubernetes.io/docs/concepts/containers/images/#maximum-parallel-image-pulls

hqhqhqhqhqhqhqhqhqhqhq commented 2 months ago

Hi @JonathanSiemering, thanks for raising this. I have checked the Azure AKS service, and these configs are currently not supported. Found this: https://github.com/Azure/AKS/issues/3879 which looks relevant.

JonathanSiemering commented 2 months ago

Hi @hqhqhqhqhqhqhqhqhqhqhq, that i have missed. Luckily it's planned for development on the aks side already. Can the issue stay open for the period of time or should i reopen it?

hqhqhqhqhqhqhqhqhqhqhq commented 2 months ago

Hi @hqhqhqhqhqhqhqhqhqhqhq, that i have missed. Luckily it's planned for development on the aks side already. Can the issue stay open for the period of time or should i reopen it?

I would recommend closing it for now and reopen it in future, thanks!

JonathanSiemering commented 2 months ago

Hi @JonathanSiemering, thanks for raising this. I have checked the Azure AKS service, and these configs are currently not supported. Found this: Azure/AKS#3879 which looks relevant.

Wait for AKS feature to be implemented.

github-actions[bot] commented 1 month ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.