hashicorp / terraform-provider-azurerm

Terraform provider for Azure Resource Manager
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs
Mozilla Public License 2.0
4.59k stars 4.63k forks source link

Argument list too long - make test #27582

Open zachrousseau opened 2 weeks ago

zachrousseau commented 2 weeks ago

Is there an existing issue for this?

Community Note

Terraform Version

1.9.7

AzureRM Provider Version

n/a

Affected Resource(s)/Data Source(s)

n/a

Terraform Configuration Files

n/a

Debug Output/Panic Output

$ make test
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
==> Checking for use of gradually deprecated functions...
==> Checking for use of deprecated functions...
==> Running Unit Tests...
./scripts/run-test.sh: line 8: /c/Program Files/Go/bin/go: Argument list too long
make: *** [GNUmakefile:85: test] Error 1

Expected Behaviour

make test runs successfully

Actual Behaviour

Error: Argument list too long

Steps to Reproduce

mkdir -p $GOPATH/src/github.com/hashicorp; cd $GOPATH/src/github.com/hashicorp
git clone git@github.com:hashicorp/terraform-provider-azurerm
cd $GOPATH/src/github.com/hashicorp/terraform-provider-azurerm
make build
make test

This can be fixed by specifying a specific package i.e.

make test TEST=./internal/services/network

It might be beneficial to document that in /DEVELOPER.md OR update /GNUmakefile to include a similar validation to test-compile: on line 87.

Should I take a run at this?

Important Factoids

No response

References

No response

rcskosir commented 2 weeks ago

Thank you for taking the time to open this issue. https://github.com/hashicorp/terraform-provider-azurerm/issues/27507 Adding a related link to an issue tracking community feedback on our contributing guides.