Please vote on this PR by adding a :thumbsup: reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review
Description
Updated web app to accept a value for client_secret_setting_name. The change is valid for both Windows and Linux, as well as the related slot resources.
For backward compatibility, if the property is not defined it will use as default the generated name.
Updated the relevant Test cases to include verification of the value.
Updated docs (as bonus, fixed some linting errors).
[x] I have checked to ensure there aren't other open Pull Requests for the same update/change.
[x] I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
[x] I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
[x] I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
Changes to existing Resource / Data Source
[x] I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
[x] I have written new tests for my resource or datasource changes & updated any relevant documentation.
[x] I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
Testing
[x] My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccWindowsWebApp_authV2CustomOIDC -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccWindowsWebApp_authV2CustomOIDC
=== PAUSE TestAccWindowsWebApp_authV2CustomOIDC
=== CONT TestAccWindowsWebApp_authV2CustomOIDC
--- PASS: TestAccWindowsWebApp_authV2CustomOIDC (695.30s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice 695.783s
TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccLinuxWebApp_authV2CustomOIDC -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccLinuxWebApp_authV2CustomOIDC
=== PAUSE TestAccLinuxWebApp_authV2CustomOIDC
=== CONT TestAccLinuxWebApp_authV2CustomOIDC
--- PASS: TestAccLinuxWebApp_authV2CustomOIDC (995.79s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice 996.185s
Community Note
Description
client_secret_setting_name. The change is valid for both Windows and Linux, as well as the related slot resources.PR Checklist
Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_linux_web_app-auth_settings_v2.custom_oidc_v2.client_secret_setting_nameproperty now can be defined [GH-28022]azurerm_linux_web_app_slot-auth_settings_v2.custom_oidc_v2.client_secret_setting_nameproperty now can be defined [GH-28022]azurerm_windows_web_app-auth_settings_v2.custom_oidc_v2.client_secret_setting_nameproperty now can be defined [GH-28022]azurerm_windows_web_app_slot-auth_settings_v2.custom_oidc_v2.client_secret_setting_nameproperty now can be defined [GH-28022]This is a (please select all that apply):
Related Issue(s)
Fixes #27988