hashicorp / terraform-provider-azurerm

Terraform provider for Azure Resource Manager
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs
Mozilla Public License 2.0
4.61k stars 4.65k forks source link

New Resource: `azurerm_cognitive_rai_policy` - Azure OpenAI Content Filters #28024

Closed feliperezende-barbosa closed 4 days ago

feliperezende-barbosa commented 5 days ago

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/cognitive -run=TestAccCognitiveRaiPolicySequential -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccCognitiveRaiPolicySequential
=== RUN   TestAccCognitiveRaiPolicySequential/rai_policy
=== RUN   TestAccCognitiveRaiPolicySequential/rai_policy/basic
=== RUN   TestAccCognitiveRaiPolicySequential/rai_policy/requiresImport
=== RUN   TestAccCognitiveRaiPolicySequential/rai_policy/complete
=== RUN   TestAccCognitiveRaiPolicySequential/rai_policy/update
--- PASS: TestAccCognitiveRaiPolicySequential (657.69s)
    --- PASS: TestAccCognitiveRaiPolicySequential/rai_policy (657.69s)
        --- PASS: TestAccCognitiveRaiPolicySequential/rai_policy/basic (170.80s)
        --- PASS: TestAccCognitiveRaiPolicySequential/rai_policy/requiresImport (163.97s)
        --- PASS: TestAccCognitiveRaiPolicySequential/rai_policy/complete (151.59s)
        --- PASS: TestAccCognitiveRaiPolicySequential/rai_policy/update (171.34s)
PASS
ok          github.com/hashicorp/terraform-provider-azurerm/internal/services/cognitive        659.331s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

Related Issue(s)

Fixes #0000

[!NOTE] If this PR changes meaningfully during the course of review please update the title and description as required.

liuwuliuyun commented 4 days ago

Hi @feliperezende-barbosa , it's great to see your enthusiasm for contributing to the AzureRM provider. I wanted to let you know that I've also submitted a similar PR recently. To prevent overlap, the maintainers might close this PR. But your contribution is definately encouraged and highly valued. Feel free to reach out to me via Teams or email within the Microsoft system. We can discuss how you can continue contributing to the Cognitive resource provider or other RPs, ensuring our efforts aren't duplicated. Also, the contributing documentation can be quite useful for your ongoing contributions. Thanks and hope you have a good day :)

stephybun commented 4 days ago

Thanks for this contributrion @feliperezende-barbosa! As @liuwuliuyun mentioned, there is already a PR adding support for this resource. Since theirs was opened first I'm going to close this one in favour of #28013.