`azurerm_eventhub` - deprecate `namespace_name` in favour of `namespace_id`

catriona-m commented 1 day ago

Community Note

Please vote on this PR by adding a :thumbsup: reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

[x] I have followed the guidelines in our Contributing Documentation.
[x] I have checked to ensure there aren't other open Pull Requests for the same update/change.
[x] I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
[x] I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
[x] I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work. For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

[ ] I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
[ ] I have written new tests for my resource or datasource changes & updated any relevent documentation.
[ ] I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
[ ] (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

[ ] My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Testing in TC

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_eventhub - deprecate namespace_name in favour of namespace_id [GH-00000]

This is a (please select all that apply):

Fixes #27008

[!NOTE] If this PR changes meaningfully during the course of review please update the title and description as required.

CorrenSoft commented 14 hours ago

Dumb question: Shouldn't be also the resource group deprecated?

stephybun commented 2 hours ago

@CorrenSoft not dumb at all, good catch 😄