hashicorp / terraform-provider-azurerm

Terraform provider for Azure Resource Manager
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs
Mozilla Public License 2.0
4.59k stars 4.63k forks source link

Feature Request: Add Azure Monitor Workbooks #5956

Closed ghost closed 2 years ago

ghost commented 4 years ago

This issue was originally opened by @akrone-hach as hashicorp/terraform#24241. It was migrated here as a result of the provider split. The original body of the issue is below.


Current Terraform Version

Latest

Use-cases

Add a resource in the Azure Provider to create Azure Monitor Workbooks. This would allow for out-of-the-box workbooks for each plan execution custom to the environment that was just created.

Attempted Solutions

Exporting the ARM template from the created Workbook and using the _azurerm_templatedeployment resource

Proposal

Add a resource that can create Azure Monitor Workbooks from the Terraform plan

References

Azure Monitor Workbooks Overview Create interactive reports with Azure Monitor workbooks

KrothuTheCoder commented 3 years ago

Wondering if there has been any movement on this? We have a number of teams who want to use workbooks and terraform would allow us the ability to have a proper CI/CD pipeline for workbook changes.

Tirke commented 3 years ago

I tried my hand at implementing this but it's currently not possible to create workbooks with Azure GO SDK.

khaliddermoumi commented 3 years ago

I tried my hand at implementing this but it's currently not possible to create workbooks with Azure GO SDK.

I believe we should add a corresponding feature request to the Azure Go SDK project then. If you already did this, please add a link here!

Tirke commented 3 years ago

Agreed :) Link to Azure Go SDK issue: https://github.com/Azure/azure-sdk-for-go/issues/14106#issuecomment-757618031

kaovd commented 3 years ago

@Tirke see in the issue 2015-05-01 Is being used, is it possible to try 2018-06-17-preview? Or do we only have 2015 avialiable https://github.com/Azure/azure-rest-api-specs/blob/1b0ed8edd58bb7c9ade9a27430759527bd4eec8e/specification/applicationinsights/resource-manager/Microsoft.Insights/preview/2018-06-17-preview/examples/WorkbookAdd.json

Tirke commented 3 years ago

Hello @kaovd, API version is hardcoded in the Azure GO SDK used by the provider to create the actual resources, nothing can be done until the SDK supports this.

ahmedloai commented 2 years ago

any updates here regarding creating workbooks by terraform?

mkonopi commented 2 years ago

Azure has made the announcement that “Azure Application Gateway analytics will be retired on 29 February 2024” Where can I find the terraform code to deploy the Azure Monitor Network Insights workbook

https://azure.microsoft.com/en-ca/updates/azure-application-gateway-analytics-will-be-retired-on-29-february-2024/

bforte commented 2 years ago

Any updates on this? Is it a won't-do?

JustinGalbraith commented 2 years ago

I saw that a new go SDK was recently released by Azure. Does that version contain what is needed to create the resource? https://azure.microsoft.com/en-us/updates/general-availability-azure-sdk-for-go/

tombuildsstuff commented 2 years ago

@ms-zhenhua is looking into this

ljsg commented 2 years ago

@ms-zhenhua it looks like this was reverted from going into the latest release, what is the plan for this feature? When can we expect it to be released?

ms-zhenhua commented 2 years ago

Hi @ljsg, thank you for reaching out. The latest PR for Azure Workbook is being reviewed. It will take some time for the reviewer to review it. The feature will be available after the review is completed.

VikramAIS commented 2 years ago

@ms-zhenhua When can we expect this feature release?

ms-zhenhua commented 2 years ago

Hi @VikramAIS, the PR for Azure Workbook is still under review. The feature will be released after the review is completed.

github-actions[bot] commented 2 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.