Operator 'GeoMatch' for azurerm_web_application_firewall_policy is missing

MaxiPalle commented 4 years ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

Terraform v0.12.24

provider.azurerm v2.6.0

Affected Resource(s)

azurerm_web_application_firewall_policy

Terraform Configuration Files

resource "azurerm_web_application_firewall_policy" "default" {
  name                  = "${var.identifier}-${lower(var.environment)}-gatewaywafdefaultpolicy"
  resource_group_name   = var.rg_name
  location              = var.rg_location

  custom_rules {
    name      = "blockBlacklistedCountries"
    priority  = 1
    rule_type = "MatchRule"

    match_conditions {
      match_variables {
        variable_name = "RemoteAddr"
      }

      operator           = "GeoMatch"
      negation_condition = false
      match_values       = ["AA", "BB", "XY", "YY", "ZZ"]
    }

    action = "Block"
  }
}

Expected behaviour

Custom Application Gateway WAF rule should have been created.

Actual behaviour

Error: expected custom_rules.0.match_conditions.0.operator to be one of [IPMatch Equal Contains LessThan GreaterThan LessThanOrEqual GreaterThanOrEqual BeginsWith EndsWith Regex], got GeoMatch

  on main.tf line 156, in resource "azurerm_web_application_firewall_policy" "default":
 156: resource "azurerm_web_application_firewall_policy" "default" {

Steps to Reproduce

terraform apply

References

https://www.terraform.io/docs/providers/azurerm/r/web_application_firewall_policy.html

boschcrank commented 4 years ago

Here is a one-line PR to fix the issue: https://github.com/terraform-providers/terraform-provider-azurerm/pull/7181

boschcrank commented 4 years ago

I have no idea why this is not closed, but the issue is fixed in v2.14.0.

tombuildsstuff commented 4 years ago

Closing since this has been fixed in v2.14 - thanks for the heads up @boschcrank

ghost commented 3 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

hashicorp / terraform-provider-azurerm