n1ngu
commented
4 years ago I am no authority maintaining Terraform providers whatsoever. But if I wanted a PR merged in any kind of repository:
- I would not modify hundreds of thousands of lines on thousands of files.
- I would not mix my development with a generic version upgrade that could be a separate PR.
- I would try to write meaningful commit messages. Namely no "Update 'filename'" messages.
Said this, this PR would be a nice to have feature. It looks like you have undergone a fair amount of tough work and I am sad I can't be of any further help. But from a generic "codereview" point of view, this PR is not acceptable :(
This PR is intended to add support for self hosted bitbucket servers.