prepared query: add missing RemoveEmptyTag and Name should be optional

hashicorp / terraform-provider-consul

Terraform Consul provider

https://www.terraform.io/docs/providers/consul/

Mozilla Public License 2.0

125 stars 112 forks source link

prepared query: add missing RemoveEmptyTag and Name should be optional #312

Closed ygersie closed 1 year ago

ygersie commented 2 years ago

The Name field of the JSON payload should be optional, see: https://www.consul.io/api-docs/query#name
Add missing https://www.consul.io/api-docs/query#removeemptytags

remilapeyre commented 2 years ago

Hi @ygersie, thanks for opening this PR. The API client will first need to be updated at https://github.com/hashicorp/consul before I can merge this. I will look into this.

remilapeyre commented 2 years ago

Hi @ygersie! I opened https://github.com/hashicorp/consul/pull/14244 to add this to the Consul API client. Once it is merge we will be able to add support for this in the provider.

ygersie commented 1 year ago

@remilapeyre is there any chance this can get a push?

LukasdeBoer commented 1 year ago

Looks like the required changes got merged in https://github.com/hashicorp/consul/pull/16113, I think this should now be doable :) @remilapeyre