Closed sundbry closed 1 month ago
This seems like a no-brainer and a straightforward fix. ping @remilapeyre or someone else who can merge.
+1! Any idea if this will be merged soon?
Our team also ran into this problem ...
@blake @nathancoleman
Can you guys please take a look at this and get this prioritized? this has been pending for some time I also opened github issue for tracking and this PR should fix it https://github.com/hashicorp/terraform-provider-consul/issues/410
Thank you for merging this. Any idea on when a new release will be published so we can use this resource?
Thank you, Mary
Téléchargez Outlook pour iOShttps://aka.ms/o0ukef
De : Nathan Coleman @.> Envoyé : Monday, July 15, 2024 11:28:01 AM À : hashicorp/terraform-provider-consul @.> Cc : mkeefe8 @.>; Comment @.> Objet : Re: [hashicorp/terraform-provider-consul] consul_config_entry_service_intentions: Fix NPE when optional JWT unset (PR #386)
Merged #386https://github.com/hashicorp/terraform-provider-consul/pull/386 into main.
— Reply to this email directly, view it on GitHubhttps://github.com/hashicorp/terraform-provider-consul/pull/386#event-13508199347, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC2V7YGRMSSKM6NJHVEPZ2LZMP2BDAVCNFSM6AAAAAA76ST54OVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGUYDQMJZHEZTINY. You are receiving this because you commented.Message ID: @.***>
Hi @mkeefe8 :wave:
Apologies for the delay while I was on vacation. I'm working to get a new release out this week
jwt
is an optional parameter on the service intention config. When it was not set, the plugin would segfault due to a null pointer dereference on the ServiceIntentionsConfigEntry.JWT.This adds a check for
si.JWT != nil
and skips building thejwt
payload when it is not set.Stack trace observed: