Support to update docker_container - Githubissues

hashicorp / terraform-provider-docker

As part of our introduction to self-service publishing in the Terraform Registry, this copy of the provider has been archived, and ownership has been transferred to active maintainers in the community. Please see the new location on the Terraform Registry: https://registry.terraform.io/providers/kreuzwerker/docker/latest

https://registry.terraform.io/providers/kreuzwerker/docker/latest

Mozilla Public License 2.0

132 stars 92 forks source link

Support to update docker_container #236

Closed suzuki-shunsuke closed 4 years ago

suzuki-shunsuke commented 4 years ago

This depends on https://github.com/terraform-providers/terraform-provider-docker/pull/234

Support to update docker_container

Attributes

When the following attributes are updated, the container will be update without recreation.

restart
max_retry_count
cpu_shares
memory
cpu_set
memory_swap

Note: CI fails but this error has nothing to do with this pull request

https://github.com/terraform-providers/terraform-provider-docker/issues/237 https://github.com/terraform-providers/terraform-provider-docker/pull/234#issuecomment-572841809

suzuki-shunsuke commented 4 years ago

https://github.com/terraform-providers/terraform-provider-docker/pull/234 is merged, so I'll update this pull request.

suzuki-shunsuke commented 4 years ago

Updated. Please review.

suzuki-shunsuke commented 4 years ago

Thank you for your review. I added a step to test for updating. Please review. https://github.com/terraform-providers/terraform-provider-docker/pull/236/commits/42e63b0a8dd8b2f6acbc551ebe79ccd95019ca33

suzuki-shunsuke commented 4 years ago

Thank you for your review. I updated. Please review.