search

hashicorp / terraform-provider-docker

As part of our introduction to self-service publishing in the Terraform Registry, this copy of the provider has been archived, and ownership has been transferred to active maintainers in the community. Please see the new location on the Terraform Registry: https://registry.terraform.io/providers/kreuzwerker/docker/latest
https://registry.terraform.io/providers/kreuzwerker/docker/latest
Mozilla Public License 2.0
132 stars 92 forks source link

Allow use of `source` file instead of content / content_base64 #240

Closed stephenliberty closed 4 years ago

stephenliberty commented 4 years ago

This fixes https://github.com/terraform-providers/terraform-provider-docker/issues/239 by allowing the use of just a filename, rather than the content of a file to be loaded into a container. Apparently anything over 4mb will cause an rpc failure in terraform as of 0.12 (or at least that's what I think I read in the codebase)

Note that I am hardly a Golang expert, and muddled through the best I could.

stephenliberty commented 4 years ago

Err, I don't know why the unit test about "endpoint_spec.0.mode" is broken (TestAccDockerService_fullSpec) and could use some guidance on that.

stephenliberty commented 4 years ago

@mavogel - nudging on review

mavogel commented 4 years ago

Hey @stephenliberty, sorry for the delay in reviewing your PR. Thanks for contributing! I fixed the tests, so could you rebase/merge master first, please?

stephenliberty commented 4 years ago

@mavogel - done. Simple test - just see if the container was restarted if the hash changed.