Dynect "convenient" client cannot create NS records

[hashibot]

This issue was originally opened by @syskill as hashicorp/terraform#6252. It was migrated here as part of the provider split. The original body of the issue is below.

---

This omission is decidedly inconvenient for me.

Terraform Version

Terraform v0.6.12; doesn't look like this has been fixed in master.

Affected Resource(s)

• dyn_record

  Terraform Configuration Files

resource "dyn_record" "dev_ns_0" {
    zone = "example.com"
    name = "dev"
    type = "NS"
    value = "${aws_route53_zone.dev.name_servers.0}"
}

Expected Behavior

As indicated by terraform plan output:

+ dyn_record.dev_ns_0
    fqdn:  "" => "<computed>"
    name:  "" => "dev"
    ttl:   "" => "0"
    type:  "" => "NS"
    value: "" => "ns-1337.awsdns-42.com"
    zone:  "" => "example.com"

Actual Behavior

Error applying plan:

1 error(s) occurred:

* dyn_record.dev_ns_0: Failed to create Dyn record: Failed to create Dyn RData: Invalid Dyn record type: NS

[phamann]

The go-dynect client now supports NS records as of v0.5.0. See this PR and their changelog for further details.