search

hashicorp / terraform-provider-dyn

Terraform Dyn provider. Please note: This Terraform provider is archived per our provider archiving process: https://terraform.io/docs/internals/archiving.html
https://registry.terraform.io
Mozilla Public License 2.0
7 stars 16 forks source link

add checks for record ID #25

Closed gramnani-crest closed 6 years ago

gramnani-crest commented 6 years ago

In case when someone removes a terraform managed record from remote manually, the provider is not able to detect the change. This is happening because the GetRecord method is returning nil in that case. The reason for this could be https://github.com/nesv/go-dynect/blob/master/dynect/client.go#L176-L179 i.e. if content length is 0 then nil is returned.

imjoshholloway commented 6 years ago

This would be really useful to have. Any chance of getting this merged?

derekargueta commented 6 years ago

+1, although a unit test would be good. ping @radeksimko