lhagemann
commented
5 years ago The changes in this PR cause the acceptance tests to fail. the testAccCheckDynRecordDestroy function fails to clean up, and therefore the tests fail as the records exist.
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -timeout 120m
? github.com/terraform-providers/terraform-provider-dyn [no test files]
=== RUN TestAccImportDynRecord_A
--- FAIL: TestAccImportDynRecord_A (2.67s)
testing.go:434: Step 0 error: After applying this step, the plan was not empty:
DIFF:
CREATE: dyn_record.foobar
fqdn: "" => "<computed>"
name: "" => "terraform" (forces new resource)
ttl: "" => "3600"
type: "" => "A" (forces new resource)
value: "" => "192.168.0.10"
zone: "" => "amdpwimexample.com" (forces new resource)
STATE:
<no state>
=== RUN TestAccImportDynRecord_MX
--- FAIL: TestAccImportDynRecord_MX (1.56s)
testing.go:434: Step 0 error: After applying this step, the plan was not empty:
DIFF:
CREATE: dyn_record.foobar
fqdn: "" => "<computed>"
name: "" => "mail-test" (forces new resource)
ttl: "" => "30"
type: "" => "MX" (forces new resource)
value: "" => "10 mx.terraform.io"
zone: "" => "amdpwimexample.com" (forces new resource)
STATE:
<no state>
=== RUN TestProvider
--- PASS: TestProvider (0.00s)
=== RUN TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN TestAccDynRecord_Basic
--- FAIL: TestAccDynRecord_Basic (0.67s)
testing.go:434: Step 0 error: Error applying: 1 error(s) occurred:
* dyn_record.foobar: 1 error(s) occurred:
* dyn_record.foobar: Failed to create Dyn record: server responded with 400 Bad Request: {"status": "failure", "data": {}, "job_id": 790733941, "msgs": [{"INFO": "make: Cannot duplicate existing record data", "SOURCE": "DYN", "ERR_CD": "TARGET_EXISTS", "LVL": "ERROR"}, {"INFO": "add: Record not added", "SOURCE": "BLL", "ERR_CD": null, "LVL": "INFO"}]}
=== RUN TestAccDynRecord_noTTL
--- FAIL: TestAccDynRecord_noTTL (0.70s)
testing.go:434: Step 0 error: Error applying: 1 error(s) occurred:
* dyn_record.foobar: 1 error(s) occurred:
* dyn_record.foobar: Failed to create Dyn record: server responded with 400 Bad Request: {"status": "failure", "data": {}, "job_id": 790733974, "msgs": [{"INFO": "make: Cannot duplicate existing record data", "SOURCE": "DYN", "ERR_CD": "TARGET_EXISTS", "LVL": "ERROR"}, {"INFO": "add: Record not added", "SOURCE": "BLL", "ERR_CD": null, "LVL": "INFO"}]}
=== RUN TestAccDynRecord_Updated
--- FAIL: TestAccDynRecord_Updated (0.66s)
testing.go:434: Step 0 error: Error applying: 1 error(s) occurred:
* dyn_record.foobar: 1 error(s) occurred:
* dyn_record.foobar: Failed to create Dyn record: server responded with 400 Bad Request: {"status": "failure", "data": {}, "job_id": 790734003, "msgs": [{"INFO": "make: Cannot duplicate existing record data", "SOURCE": "DYN", "ERR_CD": "TARGET_EXISTS", "LVL": "ERROR"}, {"INFO": "add: Record not added", "SOURCE": "BLL", "ERR_CD": null, "LVL": "INFO"}]}
=== RUN TestAccDynRecord_Multiple
--- FAIL: TestAccDynRecord_Multiple (3.36s)
testing.go:434: Step 0 error: Check failed: Check 1/11 error: Not found: dyn_record.foobar1
=== RUN TestAccDynRecord_CNAME_trailingDot
--- FAIL: TestAccDynRecord_CNAME_trailingDot (0.60s)
testing.go:434: Step 0 error: Error applying: 1 error(s) occurred:
* dyn_record.foobar: 1 error(s) occurred:
* dyn_record.foobar: Failed to create Dyn record: server responded with 400 Bad Request: {"status": "failure", "data": {}, "job_id": 790734179, "msgs": [{"INFO": "make: Cannot add a CNAME at a node with data", "SOURCE": "DYN", "ERR_CD": "ILLEGAL_OPERATION", "LVL": "ERROR"}, {"INFO": "add: Record not added", "SOURCE": "BLL", "ERR_CD": null, "LVL": "INFO"}]}
=== RUN TestAccDynRecord_CNAME_topLevelDomain
--- FAIL: TestAccDynRecord_CNAME_topLevelDomain (0.66s)
testing.go:434: Step 0 error: Error applying: 1 error(s) occurred:
* dyn_record.foobar: 1 error(s) occurred:
* dyn_record.foobar: Failed to create Dyn record: server responded with 400 Bad Request: {"status": "failure", "data": {}, "job_id": 790734213, "msgs": [{"INFO": "make: Cannot duplicate existing record data", "SOURCE": "DYN", "ERR_CD": "TARGET_EXISTS", "LVL": "ERROR"}, {"INFO": "add: Record not added", "SOURCE": "BLL", "ERR_CD": null, "LVL": "INFO"}]}
=== RUN TestAccDynRecord_NS_record
--- FAIL: TestAccDynRecord_NS_record (0.85s)
testing.go:434: Step 0 error: Error applying: 1 error(s) occurred:
* dyn_record.foobar: 1 error(s) occurred:
* dyn_record.foobar: Failed to create Dyn record: server responded with 400 Bad Request: {"status": "failure", "data": {}, "job_id": 790734257, "msgs": [{"INFO": "make: Cannot duplicate existing record data", "SOURCE": "DYN", "ERR_CD": "TARGET_EXISTS", "LVL": "ERROR"}, {"INFO": "add: Record not added", "SOURCE": "BLL", "ERR_CD": null, "LVL": "INFO"}]}
=== RUN TestAccDynRecord_MX_record
--- FAIL: TestAccDynRecord_MX_record (0.70s)
testing.go:434: Step 0 error: Error applying: 1 error(s) occurred:
* dyn_record.foobar: 1 error(s) occurred:
* dyn_record.foobar: Failed to create Dyn record: server responded with 400 Bad Request: {"status": "failure", "data": {}, "job_id": 790734299, "msgs": [{"INFO": "make: Cannot duplicate existing record data", "SOURCE": "DYN", "ERR_CD": "TARGET_EXISTS", "LVL": "ERROR"}, {"INFO": "add: Record not added", "SOURCE": "BLL", "ERR_CD": null, "LVL": "INFO"}]}
FAIL
FAIL github.com/terraform-providers/terraform-provider-dyn/dyn 12.467s
make: *** [GNUmakefile:17: testacc] Error 1
Reverts terraform-providers/terraform-provider-dyn#25