search

hashicorp / terraform-provider-dyn

Terraform Dyn provider. Please note: This Terraform provider is archived per our provider archiving process: https://terraform.io/docs/internals/archiving.html
https://registry.terraform.io
Mozilla Public License 2.0
7 stars 16 forks source link

Bump go-dynect client version to v0.5.1 #9

Closed phamann closed 7 years ago

phamann commented 7 years ago

The go-dynect client that this provider uses has had multiple improvements over the last year. This simply bumps the pinned vendor version to v0.5.1. I have ran the tests and all succeeded.

This fixes at least these issues, but potentially more:

radeksimko commented 7 years ago 
make testacc TEST=./dyn
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./dyn -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccDynRecord_Basic
--- PASS: TestAccDynRecord_Basic (18.06s)
=== RUN   TestAccDynRecord_Updated
--- FAIL: TestAccDynRecord_Updated (17.88s)
    testing.go:428: Step 1 error: Error applying: 1 error(s) occurred:

        * dyn_record.foobar: 1 error(s) occurred:

        * dyn_record.foobar: Failed to update Dyn record: server responded with 404 Not Found: {"status": "failure", "data": {}, "job_id": 3952906211, "msgs": [{"INFO": "id: You did not reference a specific record", "SOURCE": "BLL", "ERR_CD": "NOT_FOUND", "LVL": "ERROR"}, {"INFO": "update: No record updated", "SOURCE": "BLL", "ERR_CD": null, "LVL": "INFO"}]}
=== RUN   TestAccDynRecord_Multiple
--- PASS: TestAccDynRecord_Multiple (22.75s)
FAIL
exit status 1
FAIL    github.com/terraform-providers/terraform-provider-dyn/dyn   58.708s

That single test was constantly failing every day since 5th June, so I'm assuming it's unrelated. Also upgrading the client gives is much more useful error message. 😃 The old one was

* dyn_record.foobar: Failed to update Dyn record: Bad response, got "404 Not Found"

Thanks 👍

phamann commented 7 years ago

@radeksimko What is the process for releasing this provider? This PR was merged a while ago but there hasn't been a release since.