hashicorp / terraform-provider-google

Terraform Provider for Google Cloud Platform
https://registry.terraform.io/providers/hashicorp/google/latest/docs
Mozilla Public License 2.0
2.33k stars 1.73k forks source link

Add support for Cloud Armor Edge policies #10761

Closed jasondamour closed 2 years ago

jasondamour commented 2 years ago

Community Note

Description

GCP Cloud Armor security policies (compute_security_policy) have a type field, which must be set to CLOUD_ARMOR_EDGE to support edge rules for Backend Buckets.

https://cloud.google.com/compute/docs/reference/rest/beta/securityPolicies (search for CLOUD_ARMOR_EDGE)

New or Affected Resource(s)

Potential Terraform Configuration

# Note "type"
resource "google_compute_security_policy" "policy" {
  name = "my-policy"
  type = "CLOUD_ARMOR_EDGE"

  rule {
    action   = "allow"
    priority = "2147483647"
    match {
      versioned_expr = "SRC_IPS_V1"
      config {
        src_ip_ranges = ["*"]
      }
    }
    description = "default rule"
  }
}

# Note "security_policy"
resource "google_compute_backend_bucket" "image_backend" {
  name        = "image-backend-bucket"
  description = "Contains beautiful images"
  bucket_name = google_storage_bucket.image_bucket.name
  enable_cdn  = true

  security_policy = google_compute_security_policy.policy.self_link
}

References

dgteixeira commented 2 years ago

Great request! We are currently implementing this on a project and it would be amazing to be able to create it through terraform!

Ubaldo-Brea commented 2 years ago

This request will be an effective solution to our project because today, we only configure it by GCP UI!

moektel commented 2 years ago

Hello,

Was wondering if I can do anything to support getting this complete and released.

This type of resource has been a big ask from my team and I would be happy to contribute to see it though

Ubaldo-Brea commented 2 years ago

Hi Team, We really need this to help us on Lift and Shift migration projects that are using Cloud Armor with storage backends. Thank you!

github-actions[bot] commented 2 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.