hashicorp / terraform-provider-google

Terraform Provider for Google Cloud Platform
https://registry.terraform.io/providers/hashicorp/google/latest/docs
Mozilla Public License 2.0
2.29k stars 1.72k forks source link

Enhance resource google_cloud_tasks_queue to support adding bucket_size #11009

Open vchinthalatf opened 2 years ago

vchinthalatf commented 2 years ago

Affected Resource(s)

I am trying to create resource "google_cloud_tasks_queue" with bucket_size = 500 but I get error

Error: Unsupported argument on main.tf line 1059, in resource "google_cloud_tasks_queue" "messaging-send-sms-svc-events": 1059: bucket_size = 500 An argument named "bucket_size" is not expected here.

resource creation script: resource "google_cloud_tasks_queue" "messaging-send-sms-svc-events" { provider = google-beta project = var.sector_project_id name = "messaging--send-sms-svc-events" location = var.cloudtasks_location rate_limits { max_concurrent_dispatches = 1000 max_dispatches_per_second = 500 } retry_config { min_backoff = "1s" max_backoff = "900s" max_attempts = 700 } bucket_size = 500 }

Proposal I am able to create cloud task queue with batch_size using the gcloud app deploy queue.yml command; so the same should be doable using terraform.

queue.yml content: queue:

name: messaging--send-sms-svc-events rate: 500/s max_concurrent_requests: 1000 bucket_size: 500 retry_parameters: min_backoff_seconds: 1 max_backoff_seconds: 900 task_retry_limit: 700

b/302797677

vchinthalatf commented 2 years ago

can someone update on this issue?

roaks3 commented 11 months ago

Note: Per the docs https://cloud.google.com/tasks/docs/reference/rest/v2/projects.locations.queues, it looks like maxBurstSize supersedes bucket_size, but it is computed by the server, and instead maxDispatchesPerSecond should be set. However, I am not familiar enough with this resource to know if that covers the use case here.