search

hashicorp / terraform-provider-google

Terraform Provider for Google Cloud Platform
https://registry.terraform.io/providers/hashicorp/google/latest/docs
Mozilla Public License 2.0
2.25k stars 1.7k forks source link

Remove instances of schema.ConfigModeAttr #12824

Open rileykarson opened 1 year ago

rileykarson commented 1 year ago

ConfigMode: schema.ConfigModeAttr is a setting that enables Attributes as blocks mode (https://www.terraform.io/language/attr-as-blocks) in Terraform, which corrected a breakage in Terraform Core between 0.11 and 0.12. It allows empty blocks to be specified, which is important to allow unsetting certain fields. However, it can result in negative behaviour for modules and advanced configurations, so we should try and remove occurrences of the setting.

This likely means attempting to correct O+C fields or similar. We've never scoped what removing this looks like.

c2thorn commented 1 month ago

Noting that schema.ConfigModeAttr affected https://github.com/hashicorp/terraform-provider-google/issues/18115