google_vertex_ai_featurestore_entitytype doesnt expose API force destroy option

[ben-marengo-msmg]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

google_vertex_ai_featurestore_entitytype doesn't expose force destroy option. please can you expose it?

New or Affected Resource(s)

• google_vertex_ai_featurestore_entitytype

Potential Terraform Configuration

resource "google_vertex_ai_featurestore_entitytype" "my_entity_type" {
  provider     = google-beta
  name         = "my_entity_type"
  featurestore = google_vertex_ai_featurestore.featurestore.id
  force_destroy = true
}

References

see the rest api for it here:

• https://cloud.google.com/vertex-ai/docs/reference/rest/v1/projects.locations.featurestores.entityTypes/delete
• https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/vertex_ai_featurestore_entitytype

b/305278584

[rileykarson]

Note: We'd want to expose this through a deletion_policy field.

[shotarok]

@rileykarson It seems google_vertex_ai_featurestore supports deletion_policy = true as @ben-marengo-msmg proposed. I wonder if supporting deletion_policy in the google_vertex_ai_featurestore _entitytype is less confusing. What do you think?

• https://cloud.google.com/vertex-ai/docs/reference/rest/v1/projects.locations.featurestores/delete
• https://github.com/GoogleCloudPlatform/magic-modules/blob/c6ecf9c6afba568ac50d9c0923f268e4c0461c54/mmv1/templates/terraform/pre_delete/vertex_ai_force_delete.go.erb#L4
• https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/vertex_ai_featurestore#force_destroy

[melinath]

It looks like feature store supports force_destroy, which maps to the force query param on the deletion method. Normally force_destroy would mean that a resource can't be deleted unless force_destroy is set; our current best practice would be to use a field called deletion_protection instead. However, for feature store, deletion is not prevented unless there are child resources. So, this is more like a deletion_policy field.

See https://googlecloudplatform.github.io/magic-modules/best-practices/#deletion-policy for more information on deletion_policy.