Support turning off cluster autoscaler in google_container_node_pool

[talonx]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The google_container_node_pool resource does not support turning off the cluster autoscaler. It has an autoscaling configuration block which just has options to set the max and min nodes, but not turn it off entirely.

This feature is available in the GKE console, which means it must be part of the GKE API also.

New or Affected Resource(s)

• https://registry.terraform.io/providers/hashicorp/google/4.58.0
• google_container_node_pool

Potential Terraform Configuration

NA

References

• 0000

b/299601056

[rileykarson]

I think that this might get turned off by setting certain settings- the Console may display it differently than the API representation

[edwardmedia]

enabled is available at its api. https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1beta1/projects.locations.clusters.nodePools#NodePool.NodePoolAutoscaling

[parupappa]

@talonx @rileykarson I would like to pick this issue up . I will add the PR.

[nemethloci]

I've just tested this and at least the removal of the whole autoscaler block disables autoscaling:

  dynamic "autoscaling" {
    for_each = lookup(each.value, "autoscaling", true) ? [each.value] : []
    content {
      min_node_count = lookup(autoscaling.value, "min_count", 1)
      # The following number will retermine the maxumum number of nodes per location = zone, which
      # means we'll have 3x this much nodes in the pool distributed ~ evenly between the 3 zones
      # https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1/projects.locations.clusters.nodePools#nodepoolautoscaling
      max_node_count = lookup(autoscaling.value, "max_count", 10)
    }
  }