Provider v5 upgrade wants to replace `google_project_service`s

[matalo33]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
• Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.
• If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

terraform 1.6.1 provider 5.0.0

Affected Resource(s)

• google_project
• google_project_service

Terraform Configuration Files

resource "google_project" "this" {
  name                = "cicd-agents-dev"
  project_id          = "cicd-agents-dev-abcd"
  folder_id           = var.folder_id
  billing_account     = var.billing_account
}

resource "google_project_service" "core" {
  for_each = toset([
    "cloudapis.googleapis.com",
    "compute.googleapis.com",
  ])
  project                    = google_project.this.id
  service                    = each.key
  disable_dependent_services = true
}

Expected Behavior

no-op

Actual Behavior

  # module.project.google_project_service.core["compute.googleapis.com"] must be replaced
-/+ resource "google_project_service" "core" {
      ~ id                         = "cicd-agents-dev-abcd/compute.googleapis.com" -> (known after apply)
      ~ project                    = "cicd-agents-dev-abcd" -> "projects/cicd-agents-dev-abcd" # forces replacement
        # (3 unchanged attributes hidden)
    }

Steps to Reproduce

Upgrading the provider to v5 causes terraform to want to recreate all enabled project services. I confirmed running plan & apply does actually disable the APIs before enabling them again.

It seems this might be because the id attribute of the google_project has changed from <project id> to projects/<project id>

This does not appear to be mentioned in the change log, or the v5 upgrade guide.

Have we done something wrong here, or is this behaviour that others are experiencing? Lastly, what is the best way to work around this issue? Running this apply is obviously very disruptive.

b/306360723

[edwardmedia]

CompareResourceNames is used

[jrybak0]

To workaround I added a lifecycle argument:

lifecycle {

Workaround for https://github.com/hashicorp/terraform-provider-google/issues/16284

ignore_changes = [project]

}

[vishesssh]

As @edwardmedia mentioned CompareResourceNames is used which is actually taking care of always trimming the id. I couldn't reproduce the issue because I have no service created before this change.

I couldn't find any changelog too as you mentioned. Can you please try to reproduce once again?