hashicorp / terraform-provider-google

Terraform Provider for Google Cloud Platform
https://registry.terraform.io/providers/hashicorp/google/latest/docs
Mozilla Public License 2.0
2.27k stars 1.72k forks source link

[Feature Request] Terraform support for pubsub latest feature `Write to cloud storage` subscription #16596

Closed gomrinal closed 9 months ago

gomrinal commented 9 months ago

Community Note

Description

Please add support for pubsub latest feature i.e write to cloud storage from pubsub. This new feature in pubsub helps user to directly write to GCS bucket so no dataflow pipeline is required in between the pubsub <-> cloud storage if no ETL is required in the middle

New or Affected Resource(s)

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.

References

b/313620098

gomrinal commented 9 months ago

IMG_4266

gomrinal commented 9 months ago

Reference: https://cloud.google.com/pubsub/docs/create-cloudstorage-subscription

SarahFrench commented 9 months ago

Implementing this feature request appears to be adding support for thecloudStorageConfig PubSub API field to the google_pubsub_subscription resource.

From a quick look, there doesn't seem to be an equivalent to this in the Eventarc API (figured I'd check as you can achieve lots of similar things with google_eventarc_trigger and google_pubsub_* resources). If this feature was also possible via Eventarc I'd expect to see GCS Bucket as an option for the destination field in the API but that isn't listed.

kamalaboulhosn commented 9 months ago

This already exists: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/pubsub_subscription#example-usage---pubsub-subscription-push-cloudstorage

SarahFrench commented 9 months ago

Oops, thanks for pointing that out @kamalaboulhosn ! Closing this issue as completed.

github-actions[bot] commented 8 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.