hashicorp / terraform-provider-google

Terraform Provider for Google Cloud Platform
https://registry.terraform.io/providers/hashicorp/google/latest/docs
Mozilla Public License 2.0
2.31k stars 1.73k forks source link

Failing test(s): TestAccComputeSharedReservation_update #16742

Open SarahFrench opened 9 months ago

SarahFrench commented 9 months ago

Failure rates

Impacted tests

Affected Resource(s)

Nightly build test history

Message(s)


Copy to clipboard
------- Stdout: -------
=== RUN   TestAccComputeSharedReservation_update
=== PAUSE TestAccComputeSharedReservation_update
=== CONT  TestAccComputeSharedReservation_update
    vcr_utils.go:152: Step 3/6 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
        stdout
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          + create
        Terraform will perform the following actions:
          # google_project_service.compute_fourth_project will be created
          + resource "google_project_service" "compute_fourth_project" {
              + disable_on_destroy = false
              + id                 = (known after apply)
              + project            = "tf-test-4oi6kdxsc31"
              + service            = "compute.googleapis.com"
            }
        Plan: 1 to add, 0 to change, 0 to destroy.
    testing_new.go:84: Error running post-test destroy, there may be dangling resources: exit status 1
        Error: Error when reading or editing Project tf-test-2oi6kdxsc31: googleapi: Error 403: Cannot delete an inactive project.
        Details:
        [
          {
            "@type": "type.googleapis.com/google.rpc.ErrorInfo",
            "domain": "cloudresourcemanager.googleapis.com",
            "reason": "PROJECT_DELETE_INACTIVE"
          },
          {
            "@type": "type.googleapis.com/google.rpc.ResourceInfo",
            "resourceName": "projects/375549546799",
            "resourceType": "project"
          }
        ]
        , forbidden
        Error: Error when reading or editing Project tf-testoi6kdxsc31: googleapi: Error 403: Cannot delete an inactive project.
        Details:
        [
          {
            "@type": "type.googleapis.com/google.rpc.ErrorInfo",
            "domain": "cloudresourcemanager.googleapis.com",
            "reason": "PROJECT_DELETE_INACTIVE"
          },
          {
            "@type": "type.googleapis.com/google.rpc.ResourceInfo",
            "resourceName": "projects/163053503235",
            "resourceType": "project"
          }
        ]
        , forbidden
        Error: Error when reading or editing Project tf-test-4oi6kdxsc31: googleapi: Error 403: Cannot delete an inactive project.
        Details:
        [
          {
            "@type": "type.googleapis.com/google.rpc.ErrorInfo",
            "domain": "cloudresourcemanager.googleapis.com",
            "reason": "PROJECT_DELETE_INACTIVE"
          },
          {
            "@type": "type.googleapis.com/google.rpc.ResourceInfo",
            "resourceName": "projects/682078857094",
            "resourceType": "project"
          }
        ]
        , forbidden
        Error: Error when reading or editing Project tf-test-3oi6kdxsc31: googleapi: Error 403: Cannot delete an inactive project.
        Details:
        [
          {
            "@type": "type.googleapis.com/google.rpc.ErrorInfo",
            "domain": "cloudresourcemanager.googleapis.com",
            "reason": "PROJECT_DELETE_INACTIVE"
          },
          {
            "@type": "type.googleapis.com/google.rpc.ResourceInfo",
            "resourceName": "projects/252520993855",
            "resourceType": "project"
          }
        ]
        , forbidden
--- FAIL: TestAccComputeSharedReservation_update (194.84s)
FAIL

b/315874487

rileykarson commented 8 months ago

@SarahFrench to split into two test failure tickets

SarahFrench commented 8 months ago

After looking at both tests failures I think I grouped these test failures together because they both involved problems when provisioning new projects (either the project itself or enabling APIs inside them) and individually the tests have very low rates of failure. TestAccComputeSharedVpc_basic 's failures are much more infrequent than those for TestAccComputeSharedReservation_update, so instead of splitting the ticket I'll just remove TestAccComputeSharedVpc_basic from this one.