hashicorp / terraform-provider-google

Terraform Provider for Google Cloud Platform
https://registry.terraform.io/providers/hashicorp/google/latest/docs
Mozilla Public License 2.0
2.36k stars 1.75k forks source link

Typo in Deprecation Warning for google_identity_platform_config? #17149

Open intotecho opened 10 months ago

intotecho commented 10 months ago

Community Note

Terraform Version

1.7.7

Affected Resource(s)

google_identity_platform_project_default_config google_identity_platform_config

Steps to Reproduce

In the documentation for google_identity_platform_project_default_config, it says that google_identity_platform_config is deprecated and replaced by, umm. google_identity_platform_config. I think it is google_identity_platform_project_default_config that is deprecated and replaced by google_identity_platform_config.

I think that is confirmed by the more informative terraform plan deprecation warning.

Warning: Deprecated Resource
│
│   with module.google_identity_platform_project_default_config.default,
│   on ..module.tf line 50, in resource "google_identity_platform_project_default_config" "default":
│   50: resource "google_identity_platform_project_default_config" "default" {
│
│ `google_identity_platform_config` is deprecated and will be removed in the
│ next major release of the provider. **Use the
│ `google_identity_platform_config` resource instead. It contains a more
│ comprehensive list of fields, and was created before
│ `google_identity_platform_project_default_config**` was added.
│
│ (and one more similar warning elsewhere)

Important Factoids

References

b/323333611

edwardmedia commented 10 months ago

Both resources are available by this moment. Agreed the message is confusion. Needs update.

https://github.com/hashicorp/terraform-provider-google/blob/main/google/services/identityplatform/resource_identity_platform_project_default_config.g

https://github.com/hashicorp/terraform-provider-google/blob/main/google/services/identityplatform/resource_identity_platform_config.go

rainshen49 commented 3 weeks ago

This is now obsolete after https://github.com/GoogleCloudPlatform/magic-modules/pull/11354. Please close this issue.