Contain cluster/node surge upgrade max surge/max unavailable defaults to unusable values

[brettcurtis]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
• Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.
• If an issue is assigned to a user, that user is claiming responsibility for the issue.
• Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Terraform Version

Terraform v1.7.2

Affected Resource(s)

google_container_cluster (autoscaler) google_container_node_pool

Terraform Configuration

No response

Debug Output

No response

Expected Behavior

max_surge and max_unavailable default to 0/0 and when using surge:

Should the default work, maybe this isn't a norm but it's the first time I think I've seen it so I figured I'd toss it out here. Feel free to close it out if this is common behavior.

Actual Behavior

No response

Steps to reproduce

No response

Important Factoids

No response

References

No response

b/323650143

[edwardmedia]

Based on the doc, defaults to 0 for both attributes are questionable

[jjk-g]

@brettcurtis is this in manually created or NAP created node pools?

I do see that max_surge is Computed in the node_pool resource but just Optional in the cluster autoscaler schema.

[brettcurtis]

You're correct this is just for NAP created pools, standard node pools look good.