search

hashicorp / terraform-provider-google

Terraform Provider for Google Cloud Platform
https://registry.terraform.io/providers/hashicorp/google/latest/docs
Mozilla Public License 2.0
2.33k stars 1.74k forks source link

TeamCity: Add GHAs to run the TeamCity configuration's tests on PRs editing the TeamCity configuration #17231

Closed SarahFrench closed 8 months ago

SarahFrench commented 9 months ago

Background

There are automated tests for the TeamCity configuration but they can only be run locally by developers. We should automate running these tests to prevent bugs entering the code.

The Azure provider has pre-existing GHAs for running TeamCity tests, so we can take a lot of inspiration from them:

We should make this GHA run on PRs where files in mmv1/third_party/terraform/.teamcity are edited.

What kind of contribution is this issue about?

Related PR(s), if any:

Details

We don't need to generate the downstream provider to run these tests - we can run them directly in mmv1/third_party/terraform/.teamcity. This will continue to be true as long as those files aren't compiled (currently they're all copied unchanged into the TPG repo, and not TPGB).

SarahFrench commented 9 months ago

This issue is like a cousin of https://github.com/hashicorp/terraform-provider-google/issues/17168, but neither blocks the other.

github-actions[bot] commented 7 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.