hashicorp / terraform-provider-google

Terraform Provider for Google Cloud Platform
https://registry.terraform.io/providers/hashicorp/google/latest/docs
Mozilla Public License 2.0
2.28k stars 1.72k forks source link

Ambiguous instantiation of health checks resource objects #17457

Open woodham1 opened 6 months ago

woodham1 commented 6 months ago

Community Note

Description

I understand that health checks may be defined as an array future implementations of the terraform resource, where hypothetically at a future date we may support multiple health checks in one backend_service resource, but the description of the variable is inherently contradictory. (aside from the the fact that the variable itself is plural.)

This sentence The set of URLs to HealthCheck resources for health checking this RegionBackendService. Currently at most one health check can be specified. Should most likely be updated to read The URL to HealthCheck resources for health checking this RegionBackendService. Currently at most one health check can be specified. Written as is, specifying URLs, then clarifying the sentence afterwards is asking to "gotcha" the end user. If there needs to be a disclaimer to specify that it is a set it can be appended on the end.

I know it's not ideal, but using a plural, then specifying that plural to be incorrect in the next sentence is IMO, not very user-friendly.

New or Affected Resource(s)

compute_region_backend_service

Potential Terraform Configuration

References

No response

b/328077461

macwas commented 5 months ago

We are not going to change it and here are the reasons:

We didn't find a better description of the current state, namely that the field is an array that accepts only one element.