hashicorp / terraform-provider-google

Terraform Provider for Google Cloud Platform
https://registry.terraform.io/providers/hashicorp/google/latest/docs
Mozilla Public License 2.0
2.25k stars 1.7k forks source link

google_vmwareengine_network_peering - Does not rebuild #17817

Open DerrickTJ opened 2 months ago

DerrickTJ commented 2 months ago

Community Note

Terraform Version

1.8.0

Affected Resource(s)

google_vmwareengine_network_peering

Terraform Configuration

Before:

resource "google_vmwareengine_network_peering" "ven-peering" {
  name                                = "ven-peering"
  vmware_engine_network               = google_vmwareengine_network.ven.id
  peer_network                        = "projects/prod/global/networks/vpc"
  peer_network_type                   = "STANDARD"
}

The requested change:

resource "google_vmwareengine_network_peering" "ven-peering" {
  name                                = "ven-peering"
  vmware_engine_network               = google_vmwareengine_network.ven.id
  peer_network                        = "projects/prod/global/networks/vpc"
  peer_network_type                   = "STANDARD"
  export_custom_routes                = false
  import_custom_routes                = true
  export_custom_routes_with_public_ip = true
  import_custom_routes_with_public_ip = false
}

Debug Output

# google_vmwareengine_network_peering.ven-peering will be updated in-place
  ~ resource "google_vmwareengine_network_peering" "ven-peering" {
      ~ export_custom_routes                = true -> false
        id                                  = "projects/prod/locations/global/networkPeerings/vpc"
      ~ import_custom_routes_with_public_ip = true -> false
        name                                = "ven-peering"
        # (11 unchanged attributes hidden)
    }

Expected Behavior

Based on the output above, terraform believes it can update in place. However, you cannot edit a vmware engine peering once it has been built. It should be destroying and rebuilding.

Actual Behavior

Nothing changes but terraform things it made the change.

Steps to reproduce

  1. Build VMware engine peering
  2. Try to change VMware engine peering

Important Factoids

No response

References

No response

ggtisc commented 2 months ago

Hi @DerrickTJ!

That is right, when you update the google_vmwareengine_network_peering resource it is going to be update as you can see in this link it qualifies to take this harassment. But if you have another official source that say something different please share it.