search

hashicorp / terraform-provider-google

Terraform Provider for Google Cloud Platform
https://registry.terraform.io/providers/hashicorp/google/latest/docs
Mozilla Public License 2.0
2.36k stars 1.75k forks source link

Convert vcr_cassette_update.sh to Go #18249

Open melinath opened 6 months ago

melinath commented 6 months ago

What kind of contribution is this issue about?

Other (specify in details)

Details

vcr_cassette_update.sh is in bash; we should convert it to Go and make it reuse our VCR handling logic from https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.ci/magician/cmd/test_terraform_vcr.go. This may be a good opportunity to consider refactoring that command.

References

No response

melinath commented 5 months ago

Script is at: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.ci/scripts/go-plus/vcr-cassette-update/vcr_cassette_update.sh

Cloud Build config is here: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.ci/gcb-vcr-nightly.yml

melinath commented 3 months ago

@iyabchen could you comment here so I can assign it to you?

iyabchen commented 3 months ago

Yes, please assign this to me. And this can be closed.

melinath commented 3 months ago

We ended up having to revert the switchover in https://github.com/GoogleCloudPlatform/magic-modules/pull/11451 so I think there's still a little work to do here.