ServiceLevelObjective(SLO) goal limit should be increased to 0.9999

AmirBagaon commented 1 month ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
If you are interested in working on this issue or have submitted a pull request, please leave a comment.
If an issue is assigned to a user, that user is claiming responsibility for the issue.
Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Terraform Version & Provider Version(s)

Terraform v0.14.6 on linux amd64

provider registry.terraform.io/hashicorp/google v4.30.0

Affected Resource(s)

google_monitoring_slo

Terraform Configuration

Debug Output

No response

Expected Behavior

Recently Google updated their SLO goal to be in range of 0 < goal <= 0.9999.

Link.

Actual Behavior

Error: goal 0.999900 must be > 0 and <= 0.999

Steps to reproduce

terraform apply

Important Factoids

No response

References

No response

b/354712173

ggtisc commented 4 weeks ago

Hi @AmirBagaon!

Everything is ok according to the link you're sharing.

So if this is a proposal for an enhancement please confirm this, but if that isn't the case share with us your terraform code and your output.

AmirBagaon commented 4 weeks ago

Thanks for the answer. It seems that the current abillity of terraform is to support a SLO goal of up to 0.999 but not 0.9999. goal - (Required) The fraction of service that must be good in order for this objective to be met. 0 < goal <= 0.999 Link.

Google recently updated it from 0.999 to 0.9999, as can be seen in the link I provided: The fraction of service that must be good in order for this objective to be met. 0 < goal <= 0.9999.

If terraform does support a 0.9999 goal, can you please share a link to the release notes?

ggtisc commented 3 weeks ago

@AmirBagaon according to the documentation on terraform registry it is what it is. On the other hand, if you have any official Google source that indicates otherwise, please share it to verify the topic.

Khemi2024 commented 1 week ago

Hi @ggtisc, I can confirm that we can configure the SLO goal to: 0.999<goal<0.9999 (i.e 0.9995) via the UI and rest but unable to do so through Terraform like @AmirBagaon mentioned.

Are you able to confirm whether the plan is to update Terraform to match the ability the console and rest offers in terms of SLO goal boundaries and if not then the reasoning would be appreciated.

Thanks

ggtisc commented 3 days ago

Confirmed issue!

In Google Cloud documentation the value of the goal could be 0.9999 while in terraform can only be 0.999

etruong42 commented 1 day ago

Possible fix: https://github.com/GoogleCloudPlatform/magic-modules/pull/11248

hashicorp / terraform-provider-google