hashicorp / terraform-provider-google

Terraform Provider for Google Cloud Platform
https://registry.terraform.io/providers/hashicorp/google/latest/docs
Mozilla Public License 2.0
2.26k stars 1.7k forks source link

Failing test(s): TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update, #18657

Closed SarahFrench closed 2 weeks ago

SarahFrench commented 3 weeks ago

Impacted tests

Affected Resource(s)

Failure rates

Message(s)

=== RUN   TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update
=== PAUSE TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update
=== CONT  TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update
    vcr_utils.go:152: Step 1/4 error: Error running apply: exit status 1
        Error: Error creating EkmConnection: googleapi: Error 400: Certificate error: Certificate is expired.
          with google_kms_ekm_connection.example-ekmconnection,
          on terraform_plugin_test.tf line 19, in resource "google_kms_ekm_connection" "example-ekmconnection":
          19: resource "google_kms_ekm_connection" "example-ekmconnection" {
--- FAIL: TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update (4.14s)
FAIL

Nightly build test history

b/351843139

SarahFrench commented 3 weeks ago

These tests depend on a certificate that's stored in a secret and isn't managed by the test itself, and that certificate has expired.

tdbhacks commented 2 weeks ago

I've asked the EKM team to update the test cert and possibly use something with a long validity, I'll let you know when complete.

rishamchokshi commented 2 weeks ago

Certs should be updated, tests should be picking up the new values

tdbhacks commented 2 weeks ago

@SarahFrench whenever you have a couple mins, let us know if the tests are still failing or if we can close this issue

SarahFrench commented 2 weeks ago

Both TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update and TestAccKmsCryptoKeyVersion_externalProtectionLevelOptionsVpc have passed in the past 2 nights, closing