hashicorp / terraform-provider-google

Terraform Provider for Google Cloud Platform
https://registry.terraform.io/providers/hashicorp/google/latest/docs
Mozilla Public License 2.0
2.31k stars 1.73k forks source link

Failing test(s): TestAccProjectService_* #18933

Closed SarahFrench closed 1 month ago

SarahFrench commented 2 months ago

Impacted tests

Affected Resource(s)

Failure rates

Message(s)

------- Stdout: -------
=== RUN   TestAccProjectService_basic
=== PAUSE TestAccProjectService_basic
=== CONT  TestAccProjectService_basic
    vcr_utils.go:152: Step 2/6 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
          map[string]string{
        -   "check_if_service_has_usage_on_destroy": "false",
          }
--- FAIL: TestAccProjectService_basic (79.52s)
FAIL

Nightly build test history

b/357622778

SarahFrench commented 2 months ago

Context: https://github.com/hashicorp/terraform-provider-google/issues/17686

SarahFrench commented 2 months ago

Also see: https://github.com/GoogleCloudPlatform/magic-modules/pull/11314#discussion_r1700194469

The new error is because check_if_service_has_usage_on_destroy is a parameter in the API (i.e. is url_param_only which implies ignore_read) and wasn't added to ImportStateVerifyIgnore. Non-blocking to resolve in this PR, though.

Unless I'm missing something- it was added to some tests but not others.

rileykarson commented 2 months ago

I looked a bit more afterwards and I think we just missed it because the new tests were excluded from VCR. Incorrectly I think- they were likely copied off tests that wouldn't have succeeded (multiple fine grained resources) but only had 1 themselves.

melinath commented 1 month ago

taking this on due to high failure count.

github-actions[bot] commented 3 weeks ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.